Skip to content

test: migrate math/base/special/log1mexp to ULP-based testing - #13935

Draft
ujjwalv01 wants to merge 1 commit into
stdlib-js:developfrom
ujjwalv01:feat-math-base-special-log1mexp-ulp
Draft

test: migrate math/base/special/log1mexp to ULP-based testing#13935
ujjwalv01 wants to merge 1 commit into
stdlib-js:developfrom
ujjwalv01:feat-math-base-special-log1mexp-ulp

Conversation

@ujjwalv01

Copy link
Copy Markdown
Contributor

Resolves a part of #11352

Description

What is the purpose of this pull request?

This pull request:

  • Migrates the math/base/special/log1mexp test files from relative tolerance testing to ULP difference testing.
  • Adds the @stdlib/assert/is-almost-same-value assertion and replaces the delta = abs( y - expected[ i ] ), tol = EPS * abs( expected[ i ] ) tolerance checks with t.strictEqual( isAlmostSameValue( actual, expected[ i ], 2 ), true, 'returns expected value' ) using the minimum required ULP value of 2.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

N/A


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. labels Aug 5, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! 👋

We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm!

Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks.

Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀

For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers!

@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants