Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(messenger): Add option to copy active message ID #22018

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

ilmotta
Copy link
Contributor

@ilmotta ilmotta commented Feb 4, 2025

Fixes #21984

Summary

Add option to copy message ID when long pressing on a chat message. Similar to how it's implemented in the desktop client, the option is only visible if the user enables the DEBUG log level.

Areas that may be impacted

  • Chat

Steps to test

  1. In Advanced settings, choose log level DEBUG.
  2. Login with same profile.
  3. Long press on any message, you should see the option Copy message ID.

cc @churik

@ilmotta ilmotta self-assigned this Feb 4, 2025
@status-im-auto
Copy link
Member

status-im-auto commented Feb 4, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 72fea10 #1 2025-02-04 10:33:06 ~5 min tests 📄log
✔️ 72fea10 #1 2025-02-04 10:34:29 ~6 min android-e2e 🤖apk 📲
✔️ 72fea10 #1 2025-02-04 10:37:16 ~9 min android 🤖apk 📲
✔️ 72fea10 #1 2025-02-04 10:39:22 ~11 min ios 📱ipa 📲
✔️ 8129ea5 #2 2025-02-05 01:28:32 ~4 min tests 📄log
✔️ 8129ea5 #2 2025-02-05 01:30:53 ~7 min android-e2e 🤖apk 📲
✔️ 8129ea5 #2 2025-02-05 01:32:58 ~9 min android 🤖apk 📲
✔️ 8129ea5 #2 2025-02-05 01:34:37 ~10 min ios 📱ipa 📲

Copy link
Member

@seanstrom seanstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! ✅

@status-im-auto
Copy link
Member

100% of end-end tests have passed

Total executed tests: 11
Failed tests: 0
Expected to fail tests: 0
Passed tests: 11

Passed tests (11)

Click to expand

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
2. test_wallet_send_eth, id: 727229

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
2. test_wallet_swap_flow_mainnet, id: 741555
3. test_wallet_balance_mainnet, id: 740490
4. test_wallet_bridge_flow_mainnet, id: 741612
5. test_wallet_send_flow_mainnet, id: 741554

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Device sessions

2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Device sessions

@pavloburykh pavloburykh self-assigned this Feb 4, 2025
@pavloburykh
Copy link
Contributor

@ilmotta thank you for the PR! no issues from my side, ready for merge.

What has been tested:

  1. Copy message id option is available upon longtap on messages (checked different types, i.e text, image, mention, link etc) in 1-1/group/community chats
  2. Copy message id option is available only when debug level = DEBUG
  3. Copied message id can be found in DEBUG log file
  4. Compared message id of the same message copied on Desktop and Mobile, made sure they are the same and thus correct
  5. Checked that all options of longtap menu work as before

@ilmotta ilmotta force-pushed the ilmotta-21984/add-option-to-copy-message-id branch from 72fea10 to 8129ea5 Compare February 5, 2025 01:23
@ilmotta ilmotta merged commit 25072cf into develop Feb 5, 2025
5 checks passed
@ilmotta ilmotta deleted the ilmotta-21984/add-option-to-copy-message-id branch February 5, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: DONE
Development

Successfully merging this pull request may close these issues.

Add option to copy Message ID for debugging message reliability issues
5 participants