-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(telem)_: track raw message by type on send #6176
Open
adklempner
wants to merge
1
commit into
develop
Choose a base branch
from
feat/telem-message-by-type
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+157
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (150)
|
adklempner
force-pushed
the
feat/telem-message-by-type
branch
2 times, most recently
from
December 8, 2024 03:19
76e8d11
to
9009d00
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6176 +/- ##
============================================
- Coverage 61.27% 19.30% -41.98%
============================================
Files 833 811 -22
Lines 109910 107929 -1981
============================================
- Hits 67348 20832 -46516
- Misses 34711 84266 +49555
+ Partials 7851 2831 -5020
Flags with carried forward coverage won't be shown. Click here to find out more.
|
adklempner
force-pushed
the
feat/telem-message-by-type
branch
2 times, most recently
from
December 9, 2024 22:45
055bb1d
to
c4644e7
Compare
adklempner
changed the title
Feat/telem message by type
feat(telem)_: track raw message by type on dispatch
Dec 9, 2024
adklempner
force-pushed
the
feat/telem-message-by-type
branch
11 times, most recently
from
December 13, 2024 09:08
d94dea8
to
94a5792
Compare
adklempner
changed the title
feat(telem)_: track raw message by type on dispatch
feat(telem)_: track raw message by type on send
Dec 13, 2024
adklempner
force-pushed
the
feat/telem-message-by-type
branch
3 times, most recently
from
December 14, 2024 00:27
ebced90
to
7a3315a
Compare
adklempner
force-pushed
the
feat/telem-message-by-type
branch
from
December 19, 2024 00:22
7a3315a
to
2e23870
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sends raw message type and payload size to telemetry before sending a message using sender or data sync
Adds a reference to telemetry service to message sender
If telemetry is enabled, metric is sent anytime
transport.Track
ors.addToDataSync
is called inmessage_sender
Also sent in messenger upon
sendDataSync
Important changes:
Closes #