Theme: add comments with hex color values and SB showcase improved #19560
+291
−318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micieslak
requested review from
Khushboo-dev-cpp,
caybro,
glitchminer and
noeliaSD
and removed request for
a team
Khushboo-dev-cpp
approved these changes
Dec 11, 2025
Contributor
Khushboo-dev-cpp
left a comment
Khushboo-dev-cpp
left a comment
There was a problem hiding this comment.
This is super helpful! thanks :)
Member
✔️ status-app/prs/linux/x86_64/tests-nim/PR-19560#1 🔹 ~12 min 🔹 7278579 🔹 📦 tests/nim package |
Member
✔️ status-app/prs/linux/x86_64/tests-ui/PR-19560#1 🔹 ~14 min 🔹 7278579 🔹 📦 tests/ui package |
Member
|
You can switch the color notation in Figma as well 😀 |
Member
Member
|
Another note: could you pls also update the ColorsPage.qml in Storybook as well? That makes the whole color matching and searching process a lot more helpful 🙂 |
Member
Author
It doesn't help (or I'm missing sth) bc there is rgba format e.g. |
Member
Author
@caybro good point. It actually triggered me to rebuild |
Member
Jenkins BuildsClick to see older builds (9)
|
micieslak
changed the title
noeliaSD
approved these changes
Dec 12, 2025
Colors defined via QColor(int, int, int) are not search-friendly (pairing color from Figma to name in code). To solve that, comments witch standard hex notation are added.
micieslak
force-pushed
the
chore/colors-hex-comments
branch
from
07fa75f to
ca78012
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Colors defined via
QColor(int, int, int)are not search-friendly (pairing color from Figma to name in code). To solve that, comments witch standard hex notation are added.Storybook
Colorspage is refactored to fetch colors in automatic way. No need to update it after changingThemePaletteorStatusColors.Screencast.from.12.12.2025.01.12.17.webm
Affected areas
statuscolors.h,themepalette.cppImpact on end user
no impact
Risk
no risk