Create database table for blob data sidecar quarantine #7108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etan-status
force-pushed
the
dev/etan/df-bq
branch
from
850a228 to
5572f3a
Compare
etan-status
changed the title
etan-status
changed the title
|
The quarantine DB works as is for blobs (and also for blocks in earlier commit), but it seems that a custom solution based on SQLite implicit rowid is preferred over explicit rowid through primary key. |
Add low-level interface to persist blocks by block root and sidecars by block root + index. Also support deleting junk that's been finalized and deletion of all data associated with a block root. Can pass `db.getQuarantineDB()` into the quarantine to expose the new DB tables while hiding APIs that deal with trusted data, and then use the new `beacon_chain_db_quarantine.nim` APIs to store / fetch / delete.
Fix stack usage compilation warnings using `closureScope`.
Add tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add low-level interface to persist blob data sidecars by block root + index. Also support deleting junk that's been finalized and deletion of all data associated with a block root.
Can pass
db.getQuarantineDB()into the quarantine to expose the new DB tables while hiding APIs that deal with trusted data, and then use the newbeacon_chain_db_quarantine.nimAPIs to store / fetch / delete.