nimbus initial commit #3036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

pedromiguelmiranda wants to merge 34 commits into master from dev/pedro/kikof

Contributor

pedromiguelmiranda commented Jan 29, 2025 •

edited

Loading

A full running project prototype of a nimbus consensus and execution clients as single binary.
Lot of improvements to be addressed, but this pr attempts to provide a working concept for the idea.

Pedro Miranda added 6 commits

January 22, 2025 15:10


          Added Makefile and nimble support

5ff6552


          Added README file

241c0a4


          added version file

d2014da


          minimal functional project structure:

490dac9

- chronicle support
- Added config files with support for both nimbus-eth clients configuration.
- thread model suggestion.
- Minimal nimbus config for given thread model.
- layers handlers.


          added tests

d643900


          nph formatting and correct typos

866ecc8

pedromiguelmiranda force-pushed the dev/pedro/kikof branch 2 times, most recently from e5aac41 to 709bf4b Compare

January 29, 2025 10:56

pedromiguelmiranda marked this pull request as ready for review

January 29, 2025 12:10

pedromiguelmiranda requested review from arnetheduck and tersec

February 4, 2025 14:45

tersec approved these changes

View reviewed changes

arnetheduck reviewed

View reviewed changes

Makefile Outdated Show resolved Hide resolved

arnetheduck reviewed

View reviewed changes

nimbus_unified/tests/test_nimbus_unified.nim Outdated Show resolved Hide resolved

arnetheduck reviewed

View reviewed changes

nimbus_unified/nimbus_unified.nim Outdated Show resolved Hide resolved

arnetheduck reviewed

View reviewed changes

nimbus_unified/nimbus_unified.nim Outdated Show resolved Hide resolved

arnetheduck reviewed

View reviewed changes

nimbus_unified/version.nim Show resolved Hide resolved

arnetheduck reviewed

View reviewed changes

nimbus_unified/tests/test_nimbus_unified.nim Outdated Show resolved Hide resolved

arnetheduck reviewed

View reviewed changes

nimbus_unified/tests/test_nimbus_unified.nim Outdated Show resolved Hide resolved

kdeme reviewed

View reviewed changes

nimbus_unified/version.nim Show resolved Hide resolved

pmmiranda added 3 commits

February 5, 2025 18:00


          removed deadcode


          renamed from unified to nimbus

fc7ca1b


          renamed references from unified to nimbus

0b6407d

pedromiguelmiranda marked this pull request as draft

February 17, 2025 16:31


          refined initial project:

c899700

- removed dead code.
- removed some structures not needed yet
- thread communication with shared data via channels.

pedromiguelmiranda force-pushed the dev/pedro/kikof branch from 709bf4b to 1f5d0ba Compare

February 17, 2025 16:37


          ignore nimbus on CI and Kurtosis git workflows

1f52881

pedromiguelmiranda force-pushed the dev/pedro/kikof branch 3 times, most recently from ec8d86d to d3ad892 Compare

February 18, 2025 11:00

pmmiranda added 8 commits

May 23, 2025 16:41


          - beacon node minimal config setup

2e53672

- corrected nimbus tests


          Added nimbus_beacon_node module copy.

ea6d871

 This module is a copy from nimbus_beacon_node module where
handleStartUpCmd visibility is changed to public.


          Added beacon node:

5ee4d6f

- Makefile support
- setup and handlers


          - Added nimbus_execution_client module copy

1abbc58

- minor fixes


          Added execution chain support:

0c674ea

    - Makefile support
    - setup and handlers


          Fixed behaviour on consensus layer about reading program options

ee595d9

 from command line, instead of loading the ones already filtered.


          Added graceful shutdown

107efa5


          temporary shutdown wa

7946ea5

pedromiguelmiranda marked this pull request as draft

June 25, 2025 09:22

pedromiguelmiranda force-pushed the dev/pedro/kikof branch 4 times, most recently from 0bc209a to 9750f27 Compare

July 1, 2025 22:23

pedromiguelmiranda force-pushed the dev/pedro/kikof branch from 9750f27 to 49417ec Compare

July 2, 2025 22:23

pmmiranda added 4 commits

July 2, 2025 23:48


          - Removed execution wrapper and give 'run' procedure public scope.

1f86d37

- Updated consensus wrapper with latest beacon node changes


          Fixed tests

f32c045


          Immediate shutdown workaround

c850a49


          - Added beacon node db file locks

50e0134

- minor fixes

Contributor

tersec commented Jul 15, 2025

There's a lot of duplication of nimbus_beacon_node. Maybe create a branch of nimbus-eth2 with some minimal refactorings and use that here instead?

Contributor Author

pedromiguelmiranda commented Jul 15, 2025

There's a lot of duplication of nimbus_beacon_node. Maybe create a branch of nimbus-eth2 with some minimal refactorings and use that here instead?

Yes, a quick and ugly shortcut to test different scenarios.
There is a proposal to remove this: nimbus-eth2#7299

pedromiguelmiranda force-pushed the dev/pedro/kikof branch from f071a9b to 50e0134 Compare

July 16, 2025 14:25

pmmiranda added 6 commits

July 17, 2025 12:08


          bump nimbus-eth2 to auxiliary PR

3ba61c6


          Removed beacon node wrapper with duplicated code and added

3403c5b

necessary changes.


          Changed submodule nimbus-eth2 branch to a feature

ca4d2bd

branch with all the required changes in nimbus-eth2.


          bump nimbus-eth2 to 24ec4576d3be2847dfca0fab5f0ef2e574659ea3

4e69a00


          optimized imports and code adaptations for changes in

2686ae1

eth2


          WA for nim issue nim-lang/Nim#24844

cdff969

Member

arnetheduck commented Sep 8, 2025

Superseded by #3646

arnetheduck closed this

arnetheduck deleted the dev/pedro/kikof branch

September 8, 2025 14:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet