add failed event count (#241)

![Screenshot 2024-03-12 at 2 48 34 PM](https://github.com/statsig-io/private-java-server-sdk/assets/137219293/df671441-6f6b-41b4-9446-48d940b43588)
statsig-io · Mar 13, 2024 · 6c0f222 · 6c0f222
1 parent be0f376
commit 6c0f222
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 4 deletions.
diff --git a/src/main/kotlin/com/statsig/sdk/ErrorBoundary.kt b/src/main/kotlin/com/statsig/sdk/ErrorBoundary.kt
@@ -59,12 +59,14 @@ internal class ErrorBoundary(private val apiKey: String, private val options: St
         }
     }
 
-    internal fun logException(tag: String, ex: Throwable, configName: String? = null, extraInfo: String? = null) {
+    internal fun logException(tag: String, ex: Throwable, configName: String? = null, extraInfo: String? = null, bypassDedupe: Boolean = false) {
         try {
-            if (options.localMode || options.disableAllLogging || seen.contains(ex.javaClass.name)) {
+            if (options.localMode || options.disableAllLogging) {
+                return
+            }
+            if (!bypassDedupe && seen.contains(ex.javaClass.name)) {
                 return
             }
-
             seen.add(ex.javaClass.name)
 
             val info = ex.stackTraceToString()
@@ -80,7 +82,7 @@ internal class ErrorBoundary(private val apiKey: String, private val options: St
                 "statsigMetadata": ${statsigMetadata.asJson()},
                 "configName": "$configName",
                 "setupOptions": $optionsCopy,
-                "extraInfo": $extraInfo
+                "extra": $extraInfo
             }
             """.trimIndent()
             val req =

diff --git a/src/main/kotlin/com/statsig/sdk/StatsigNetwork.kt b/src/main/kotlin/com/statsig/sdk/StatsigNetwork.kt
@@ -26,6 +26,8 @@ private const val MS_IN_S: Long = 1000
 const val STATSIG_API_URL_BASE: String = "https://statsigapi.net/v1"
 private const val STATSIG_CDN_URL_BASE: String = "https://api.statsigcdn.com/v1"
 const val LOG_EVENT_RETRY_COUNT = 5
+const val LOG_EVENT_FAILURE_TAG = "statsig::log_event_failed"
+
 internal class StatsigNetwork(
     private val sdkKey: String,
     private val options: StatsigOptions,
@@ -257,6 +259,7 @@ internal class StatsigNetwork(
                             return@coroutineScope
                         } else if (!retryCodes.contains(response.code) || currRetry == 0) {
                             options.customLogger.warning("[Statsig]: Network request failed with status code: ${response.code}")
+                            logPostLogFailure(eventsCount)
                             return@coroutineScope
                         } else if (retryCodes.contains(response.code) && currRetry > 0) {
                             options.customLogger.info("[Statsig]: Retrying network request. Retry count: $currRetry. Response code: ${response.code}")
@@ -267,6 +270,10 @@ internal class StatsigNetwork(
                     if (e is JsonParseException) {
                         errorBoundary.logException("retryPostLogs", e)
                     }
+                    if (currRetry == 0) {
+                        logPostLogFailure(eventsCount)
+                        return@coroutineScope
+                    }
                 }
 
                 val count = retries - --currRetry
@@ -278,4 +285,17 @@ internal class StatsigNetwork(
     fun shutdown() {
         statsigHttpClient.dispatcher.executorService.shutdown()
     }
+
+    private fun logPostLogFailure(eventsCount: String) {
+        errorBoundary.logException(
+            LOG_EVENT_FAILURE_TAG,
+            Exception("Drop log event"),
+            null,
+            extraInfo = """{
+               "eventCount": $eventsCount
+            }
+            """.trimIndent(),
+            bypassDedupe = true,
+        )
+    }
 }
diff --git a/src/main/kotlin/com/statsig/sdk/StatsigServer.kt b/src/main/kotlin/com/statsig/sdk/StatsigServer.kt
@@ -196,8 +196,11 @@ sealed class StatsigServer {
     ): CompletableFuture<Layer>
 
     @JvmSynthetic abstract fun overrideLayerAsync(layerName: String, value: Map<String, Any>): CompletableFuture<Unit>
+
     @JvmSynthetic abstract fun removeLayerOverrideAsync(layerName: String): CompletableFuture<Unit>
+
     @JvmSynthetic abstract fun removeConfigOverrideAsync(configName: String): CompletableFuture<Unit>
+
     @JvmSynthetic abstract fun removeGateOverrideAsync(gateName: String): CompletableFuture<Unit>
 
     abstract fun manuallyLogLayerParameterExposureAsync(user: StatsigUser, layerName: String, paramName: String): CompletableFuture<Void>
@@ -216,6 +219,7 @@ sealed class StatsigServer {
 
     @JvmSynthetic
     internal abstract suspend fun flush()
+
     @JvmSynthetic internal abstract fun getCustomLogger(): LoggerInterface
 
     companion object {