feat: add URLSession into StatsigOptions (#278)

add Configurable URLSession in iOS, default is `URLSession.shared`
statsig-io · Jun 10, 2024 · c0fef62 · c0fef62
1 parent 345133b
commit c0fef62
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/Sources/Statsig/NetworkService.swift b/Sources/Statsig/NetworkService.swift
@@ -297,7 +297,7 @@ class NetworkService {
             marker?.start(attempt: currentAttempt)
 
 
-            let task = URLSession.shared.dataTask(with: request) {
+            let task = self?.statsigOptions.urlSession.dataTask(with: request) {
                 [weak self] responseData, response, error in
 
                 marker?.end(currentAttempt, responseData, response, error)
@@ -324,8 +324,11 @@ class NetworkService {
                 }
             }
 
-            taskCapture?(task)
-            task.resume()
+            if let taskCapture = taskCapture, let task = task {
+                taskCapture(task)
+            }
+
+            task?.resume()
         }
     }
 }

diff --git a/Sources/Statsig/StatsigOptions.swift b/Sources/Statsig/StatsigOptions.swift
@@ -100,6 +100,12 @@ public class StatsigOptions {
      */
     public var customCacheKey: ((String, StatsigUser) -> String)?
 
+    /**
+     The URLSession to be used for network requests. By default, it is set to URLSession.shared.
+     This property can be customized to utilize URLSession instances with specific configurations, including certificate pinning, for enhanced security when communicating with servers.
+     */
+    public var urlSession: URLSession = .shared
+
     internal var mainApiUrl: URL?
     internal var logEventApiUrl: URL?
     var environment: [String: String] = [:]
@@ -119,7 +125,8 @@ public class StatsigOptions {
                 eventLoggingApi: String? = nil,
                 evaluationCallback: ((EvaluationCallbackData) -> Void)? = nil,
                 userValidationCallback: ((StatsigUser) -> StatsigUser)? = nil,
-                customCacheKey: ((String, StatsigUser) -> String)? = nil
+                customCacheKey: ((String, StatsigUser) -> String)? = nil,
+                urlSession: URLSession? = nil
     )
     {
         if let initTimeout = initTimeout, initTimeout >= 0 {
@@ -176,6 +183,10 @@ public class StatsigOptions {
         if let customCacheKey = customCacheKey {
             self.customCacheKey = customCacheKey
         }
+
+        if let urlSession = urlSession {
+            self.urlSession = urlSession
+        }
 
         self.overrideStableID = overrideStableID