add GetInt helper function to dynamic config #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -98,6 +98,19 @@ func (d *configBase) GetNumber(key string, fallback float64) float64 { | |||
| return fallback | |||
| } | |||
|
|
|||
| // Gets the int64 value at the given key in the DynamicConfig | |||
There was a problem hiding this comment.
Well, I think all these comments are out of date now that there is layer, and these utils exist on both types. Mind fixing that up?
| func (d *configBase) GetInt(key string, fallback int64) int64 { | ||
| if v, ok := d.Value[key]; ok { | ||
| switch val := v.(type) { | ||
| case int64: |
There was a problem hiding this comment.
should we cast other numeric types to int64? What does json give us? @daniel-statsig noticed in other SDKs that json parsing gives you only a certain set of types - does json parsing in go give an int64?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.