Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ssb-project with templates not using Jupyter Notebooks, there is no need to create a kernel and add the ipykernel dependency to the template that is to be instantiated. The
--no-kernel
option makes it possible to use ssb-project with "plain" templates.Some comments to the implementation and the three commits:
pyproject.toml
as described here. This is better than having lots of ignore comments in the code.--no-kernel
option, and a refactoring of thebuild_project
- function to decrease the function's complexity (flagged by flake8 test). Extracted thevalidate_and_fix_git_config
-part to a separate function.typer.models.OptionInfo
instead ofbool
orstr
) and this is issue 106 on the typer library. The solution is to use the recommended Annotated syntax as described in the typer documentation. I changed the code to use the Annotated syntax for alltyper.Option
parameters. And added some more tests.Have a look at it and see what you think, @mallport, @mmwinther and @Andilun.
After the PR I noted that there are problems with coverage reporting in the
test.yml
GitHub action, and that is has been there for a while. Tried to fix it, but found no quick solution.Update: Solved the coverage-problem by setting
relative_files = true
in the[tool.coverage.run]
section inpyproject.toml
.