fixed a bug where we tamper with python path before retrieving it, ca…

…using invalid python path

src/ssb_project_cli/ssb_project/build/build.py

@@ -123,6 +123,13 @@ def ipykernel_attach_bashrc(project_name: str) -> None:
     with open(kernel_json_file, encoding="utf-8") as f:
         content_as_json = json.loads(f.read())
 
+    python_executable_path = _get_python_executable_path(content_as_json["argv"])
+    if python_executable_path is None:
+        print(
+            f":x:\tCould not mount .bashrc, cannot find python executable path in {kernel_json_file}"
+        )  # noqa: B907
+        exit(1)
+
     content_as_json["argv"] = [
         f"{project_kernel_path}/python.sh",
         "-m",
@@ -136,13 +143,6 @@ def ipykernel_attach_bashrc(project_name: str) -> None:
 
     start_script_path = f"{project_kernel_path}/python.sh"
 
-    python_executable_path = _get_python_executable_path(content_as_json["argv"])
-    if python_executable_path is None:
-        print(
-            f":x:\tCould not mount .bashrc, cannot find python executable path in {kernel_json_file}"
-        )  # noqa: B907
-        exit(1)
-
     _write_start_script(start_script_path, python_executable_path)
 
     # set rx to everyone, required for jupyterlab to get permission to call start script

tests/unit/build_test/test_build.py

@@ -220,19 +220,14 @@ def test_ipykernel_attach_bashrc_kernel_json_file_not_exist(
         ]
     },
 )
-@patch(
-    f"{BUILD}.json.dumps",
-    return_value='{"argv": ["/bin/python3", "-m", "ipykernel_launcher", "-f", "{connection_file}"]}',
-)
 @patch(f"{BUILD}._get_python_executable_path", return_value=None)
 @patch(f"{BUILD}.print")
 def test_ipykernel_attach_bashrc_python_executable_path_not_found(
     mock_print: Mock,
     mock_python_executable_path: Mock,
-    mock_json_dumps: Mock,
     mock_json_loads: Mock,
-    mock_exists: Mock,
     mock_file_open: Mock,
+    mock_exists: Mock,
     mock_get_kernels_dict: Mock,
 ) -> None:
     project_name = "existing_project"
@@ -244,9 +239,8 @@ def test_ipykernel_attach_bashrc_python_executable_path_not_found(
 
     assert mock_get_kernels_dict.call_count == 1
     assert mock_exists.call_count == 2
-    assert mock_file_open.call_count == 2
+    assert mock_file_open.call_count == 1
     assert mock_json_loads.call_count == 1
-    assert mock_json_dumps.call_count == 1
     assert mock_python_executable_path.call_count == 1
     assert mock_print.call_args[0][0] == expected_print_message
     assert cm.exception.code == expected_exit_code