Skip to content

Fix InvalidVersion error from latest setuptools #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix InvalidVersion error from latest setuptools #36

wants to merge 2 commits into from

Conversation

t-silvers
Copy link

quick fix to avoid hitting a packaging.version.InvalidVersion error when installing with setuptools>=66.0.0, but note that "setup.py install is deprecated. Use build and pip and other standards-based tools" so a larger refactor is in order.

t-silvers
t-silvers commented Feb 2, 2023
View reviewed changes
Copy link
Author

@t-silvers t-silvers left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore first commit, forgot to squash

JoachimSchaeffer
JoachimSchaeffer approved these changes Jul 9, 2024
View reviewed changes
Copy link

@JoachimSchaeffer JoachimSchaeffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, and would be a good interim fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JoachimSchaeffer JoachimSchaeffer JoachimSchaeffer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@t-silvers @JoachimSchaeffer