Updated public async methods to end with Async suffix.#153
Open
tdupont750 wants to merge 1 commit intostatianzo:masterfrom
Open
Updated public async methods to end with Async suffix.#153tdupont750 wants to merge 1 commit intostatianzo:masterfrom
tdupont750 wants to merge 1 commit intostatianzo:masterfrom
Conversation
Contributor
curious, instead of ignoring them what did you end up doing with the tasks? |
Author
|
I believe that I used a concurrent queue and had a background task serially write messages to the connection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request #126 changed several public methods to become async and return a Task instead of void. This change did not include the recommended naming convention of naming all async methods with the Async suffix.
In my case, this caused us to introduce a bug to a project that was using Fleck. We would ignore Task returned from IWebSocketConnection.Send, and under high load the task scheduler would get backed up.
I have updated the the public methods to include the Async suffix. However, in order to maintain backwards compatibility, I have also added obsolete methods to the interfaces without the suffix.