Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the internal getInitialConfiguration #4441

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Remove the internal getInitialConfiguration #4441

merged 1 commit into from
Nov 10, 2023

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Nov 8, 2023

No description provided.

@Andarist Andarist requested a review from davidkpiano November 8, 2023 16:06
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4b66906

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Nov 8, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4b66906:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

Andarist
Andarist commented Nov 8, 2023
View reviewed changes
packages/core/src/stateUtils.ts
rootNode: AnyStateNode
): AnyStateNode[] {
const configuration: AnyStateNode[] = [];
const initialTransition = rootNode.initial;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that this whole function was returning an empty array for parallel roots (since they don't have .initial) and it turns out that the initial configuration is resolved anyway even without this whole function... so: 🗑️

@Andarist Andarist force-pushed the cleanup-state-creation branch from ff54f83 to 210beb0 Compare November 10, 2023 11:37
Base automatically changed from cleanup-state-creation to next November 10, 2023 11:42
@Andarist Andarist force-pushed the remove-get-initial-configuration branch from bb54418 to 4b66906 Compare November 10, 2023 11:44
@Andarist Andarist merged commit 15c786b into next Nov 10, 2023
1 check passed
@Andarist Andarist deleted the remove-get-initial-configuration branch November 10, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkpiano davidkpiano davidkpiano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andarist @davidkpiano