Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate State creation methods #4440

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Deduplicate State creation methods #4440

merged 3 commits into from
Nov 10, 2023

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Nov 8, 2023

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 1abc04f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Andarist Andarist requested a review from davidkpiano November 8, 2023 16:02
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Nov 8, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1abc04f:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

davidkpiano
davidkpiano approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@davidkpiano davidkpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a changeset

davidkpiano
davidkpiano requested changes Nov 8, 2023
View reviewed changes
Copy link
Member

@davidkpiano davidkpiano left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually need createState for an important reason: developer testing of pure logic. new State(...) is not really satisfactory since you manually have to specify the configuration and other things.

See https://discord.com/channels/795785288994652170/1171920686055428218/1171920686055428218

Base automatically changed from remove-state-tostrings to next November 10, 2023 11:36
@Andarist Andarist force-pushed the cleanup-state-creation branch from ff54f83 to 210beb0 Compare November 10, 2023 11:37
@Andarist Andarist merged commit 10d9539 into next Nov 10, 2023
1 check passed
@Andarist Andarist deleted the cleanup-state-creation branch November 10, 2023 11:42
@github-actions github-actions bot mentioned this pull request Nov 10, 2023
Merged
@Andarist Andarist mentioned this pull request Nov 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkpiano davidkpiano davidkpiano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andarist @davidkpiano