Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed State#toStrings method #4438

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Removed State#toStrings method #4438

merged 1 commit into from
Nov 10, 2023

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Nov 8, 2023

This method seems to be so niche that I don't think it has to be on State

@Andarist Andarist requested a review from davidkpiano November 8, 2023 11:21
Copy link

changeset-bot bot commented Nov 8, 2023

🦋 Changeset detected

Latest commit: f8d4fc0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Nov 8, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f8d4fc0:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

@davidkpiano
Copy link
Member

@Andarist
Copy link
Member Author

We discussed this privately and decided that it should be OK to get rid off this for now and reevaluate later if the need arises.

@Andarist Andarist merged commit 7bbf41d into next Nov 10, 2023
1 check passed
@Andarist Andarist deleted the remove-state-tostrings branch November 10, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants