[6.x] Don't reset revisions when saving a collection with the field hidden - #15431
Open
lazerg wants to merge 1 commit into
Open
[6.x] Don't reset revisions when saving a collection with the field hidden#15431lazerg wants to merge 1 commit into
lazerg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving a collection's config writes
revisions: falseinto the collection YAML on any instance where revisions are switched off, even though the toggle was never on screen. If a site keepsSTATAMIC_REVISIONS_ENABLEDtrue in production and false locally, editing anything else in the collection config from local quietly turns revisions off for everyone.The revisions field only gets added to the config blueprint when
statamic.revisions.enabledis on and the site is Pro. Without it, the submitted values carry norevisionskey at all, and the update fell back to$values['revisions'] ?? false.The setter now only runs when the field was part of the form, so a hidden toggle leaves whatever is already in the YAML alone.
There's a related one I've left alone: with revisions on,
defaultPublishState()always reportsfalse, so the config form posts that value back and the collection picks updefault_status: drafton a save that changed nothing. That needs a decision about what the getter should return rather than a guard, so it felt like a separate PR. Happy to pick it up if you want it.Fixes #15430