[6.x] Keep augmentable tag results as objects inside Antlers interpolations - #15424
Open
duncanmcclean wants to merge 1 commit into
Open
[6.x] Keep augmentable tag results as objects inside Antlers interpolations#15424duncanmcclean wants to merge 1 commit into
duncanmcclean wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YENbpFdMXXA4j68iM7Dog2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where assigning the
assettag's result to a variable, like{{ img = { asset url="/img/logo.png" } }}, gave you the URL string rather than the asset, so{{ img.alt }},{{ img.width }}and friends were empty.This was happening because tag output inside an interpolation was reduced as if it were being rendered directly, and that path casts any object with
__toString(like anAsset) to a string before the value is handed back.This PR fixes it by leaving augmentable objects alone when they're returned from a tag inside an interpolation. The Antlers runtime already knows how to work with an
Assetheld in a variable, so{{ img }}still outputs the URL, while{{ img.alt }},{{ img:width }}and looping over{{ img }}now work too.Fixes #11257