Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Filter sidebar #5714

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

WithoutPants
Copy link
Collaborator

@WithoutPants WithoutPants commented Mar 11, 2025

This is a less ambitious (see #4453) attempt at adding a filter sidebar to the scenes page.

Currently includes:

  • saved filters - save/set as default functionality moved here
  • performers
  • studios
  • tags

I intend to include rating and organised options in this PR.

Replaces the Saved Filter dropdown button with a sidebar toggle button.

image

This is currently WIP. PR is so that people can try out the build.

@WithoutPants WithoutPants added the feature Pull requests that add a new feature label Mar 11, 2025
@MinasukiHikimuna
Copy link
Collaborator

What do you think: could the expanded/collapsed state be saved? Now if I have specific tags and performers selected, open a scene and come back scenes list view, all the options are collapsed with no visual indication which of those have some options set.

Proficient Stash users can determine the options from the standard filtering options though.

@WithoutPants
Copy link
Collaborator Author

New updates from yesterday:

  • sidebar now sits overlapping the content pane on smaller viewports. Adds a close button on these viewports and will automatically close the sidebar when clicking outside the sidebar.
  • selected items now always show under the heading, instead of being hidden behind the collapse.

image

What do you think: could the expanded/collapsed state be saved? Now if I have specific tags and performers selected, open a scene and come back scenes list view, all the options are collapsed with no visual indication which of those have some options set.

Saving sidebar state in the browser is at the top of my todo list.

@echo6ix
Copy link
Contributor

echo6ix commented Mar 15, 2025

Placement of sidebar toggle and sidebar specific buttons

@WithoutPants are you open to taking inspiration from ChatGPT's sidebar UI/UX? Specifically the placement of the toggle and other relevant primary buttons, which are placed at the top

  • Toggle button is fixed (top right), regardless of sidebar being enabled or disabled
  • Fixed toggle button allows for notification badge for sidebar specific items (as per animation). Stash may not have a use for that now, but the possibility is there for the future.
  • Top of the sidebar (left justified) is a good potential placement for other fundamental buttons

screentogif

@MinasukiHikimuna
Copy link
Collaborator

What is the plan for this feature? Will it be merged to develop now that 0.28 has been released?

I'm already used to rely on this so I cannot imagine using Stash without it. Great work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants