feat(ui): TE-2363 allow user to opt in to be notified for historical anomalies when creating a subscription

[nalin-patidar]

…cription

Issue(s)

https://startree.atlassian.net/browse/TE-2363

Description

Added the ability for a user to subscribe to notification for historical anomalies.

Screenshots

https://github.com/startreedata/thirdeye/assets/174305

624/132a709a-b67b-4577-bdbf-6929598dfda0

[alcatraz627]

@nalin-patidar PR looks good, but the title check is failing. The capital "A" in the title needs to be changed to lowercase + since only one commit in this PR, will need to git commit --amend and git push -f to change the same in the commit message as well.

Read about it at https://github.com/startreedata/thirdeye/blob/master/thirdeye-ui/CONTRIBUTING.md

[cyrilou242]

@alcatraz627

PR looks good, but the title check is failing. The capital "A" in the title needs to be changed to lowercase +

could we remove such constraint? I don't see the value in lower/upper case checks

EDIT: seems it can be done here:

thirdeye/.github/workflows/check-ui-conventions.yaml

Line 42 in b87705f

subjectPattern: ^(([A-Z]+\-[0-9]+( {1}))+|\[auto\] )(?![A-Z, ]).+[^.…]$

[cyrilou242]

let's add a tooltip that explaines the feature.
I provided the tooltip message in the ticket.

You should be able to find some tooltip code in the codebase, we use some in other places

[alcatraz627]

could we remove such constraint? I don't see the value in lower/upper case checks

@cyrilou242 the thirdeye-ui conventions are based on whatever was set up for startree-ui. Though we are trying to maintain consistency for all UI projects, we should be able to get rid of such minor details like capitalization.

[jayeshchoudhary]

nit: for better readability

Suggested change

	notifyHistoricalAnomalies:
	!!subscriptionGroup.notifyHistoricalAnomalies,
	notifyHistoricalAnomalies:
	Boolean(subscriptionGroup.notifyHistoricalAnomalies),

[nalin-patidar]

Done

[jayeshchoudhary]

we should have similar component already?
how are we showing tooltips now?

[nalin-patidar]

I have commented about this in top of this file

[jayeshchoudhary]

I also see the label and info icon are not centred vertically
is the pr screenshot updated?