Skip to content

Commit

Permalink
Merge pull request #24 from startersclan/enhancement/development-do-n…
Browse files Browse the repository at this point in the history
…ot-require-docker-container-build-driver-in-development

Enhancement (development): Do not require `docker-container` build driver in development
  • Loading branch information
leojonathanoh committed Nov 2, 2023
2 parents f2f18fb + 3ee1340 commit 23b91ff
Show file tree
Hide file tree
Showing 5 changed files with 31 additions and 22 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci-master-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
if: matrix.testenv == 'dev'
run: |
set -eux
docker compose up --build -d
docker compose -f docker-compose.yml -f docker-compose.build.yml up --build -d
docker compose -f docker-compose.test.yml --profile dev up
- name: Integration test (prod)
Expand Down
3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,6 @@ echo '127.0.0.1 phpmyadmin.example.com' | sudo tee -a /etc/hosts
## Development

```sh
# Setup docker buildx builder
docker buildx create --name mybuilder --driver docker-container --use

# 1. Start Counter-strike 1.6 server, source-udp-forwarder, HLStatsX:CE stack
docker compose up --build
# HLStatsX:CE web frontend available at http://localhost:8081/. Admin Panel username: admin, password 123456
Expand Down
29 changes: 29 additions & 0 deletions docker-compose.build.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# This is a docker compose override file, for development builds with caching for CI environments
services:
daemon:
build:
cache_from:
- type=local,src=/tmp/.buildx-cache-daemon
cache_to:
- type=local,dest=/tmp/.buildx-cache-daemon,mode=max

awards:
build:
cache_from:
- type=local,src=/tmp/.buildx-cache-daemon
cache_to:
- type=local,dest=/tmp/.buildx-cache-daemon,mode=max

web:
build:
cache_from:
- type=local,src=/tmp/.buildx-cache-web
cache_to:
- type=local,dest=/tmp/.buildx-cache-web,mode=max

heatmaps:
build:
cache_from:
- type=local,src=/tmp/.buildx-cache-web
cache_to:
- type=local,dest=/tmp/.buildx-cache-web,mode=max
3 changes: 1 addition & 2 deletions docker-compose.example.build.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# This is a docker compose override file, for testing production builds
version: '2.2'
# This is a docker compose override file, for testing production builds with caching for CI environments
services:
daemon:
build:
Expand Down
16 changes: 0 additions & 16 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,6 @@ services:
dockerfile: Dockerfile.daemon
context: .
target: dev
cache_from:
- type=local,src=/tmp/.buildx-cache-daemon
cache_to:
- type=local,dest=/tmp/.buildx-cache-daemon,mode=max
ports:
- 27500:27500/udp # For external servers to send logs to the daemon
networks:
Expand All @@ -86,10 +82,6 @@ services:
dockerfile: Dockerfile.daemon
context: .
target: dev
cache_from:
- type=local,src=/tmp/.buildx-cache-daemon
cache_to:
- type=local,dest=/tmp/.buildx-cache-daemon,mode=max
stop_signal: SIGKILL
entrypoint:
- /bin/sh
Expand Down Expand Up @@ -140,10 +132,6 @@ services:
dockerfile: Dockerfile.web
context: .
target: dev
cache_from:
- type=local,src=/tmp/.buildx-cache-web
cache_to:
- type=local,dest=/tmp/.buildx-cache-web,mode=max
volumes:
- ./web:/web
# - ./config/web/supervisor.conf:/supervisor.conf:ro
Expand Down Expand Up @@ -174,10 +162,6 @@ services:
dockerfile: Dockerfile.web
context: .
target: dev
cache_from:
- type=local,src=/tmp/.buildx-cache-web
cache_to:
- type=local,dest=/tmp/.buildx-cache-web,mode=max
volumes:
- ./heatmaps:/heatmaps
- ./web:/web
Expand Down

0 comments on commit 23b91ff

Please sign in to comment.