Change (docker): Combine nginx and php to a single image for ASP with env var support for configuration
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leojonathanoh
changed the title
ASP and bf2sclone with env var support for configurationASP with env var support for configuration
leojonathanoh
force-pushed
the
change/docker-combine-nginx-and-php-to-a-single-image-for-both-asp-and-bf2sclone-with-env-var-support-for-configuration
branch
8 times, most recently
from
aef3d0f
to
2123445
Compare
leojonathanoh
force-pushed
the
change/docker-combine-nginx-and-php-to-a-single-image-for-both-asp-and-bf2sclone-with-env-var-support-for-configuration
branch
from
52eebc0
to
01fb2f4
Compare
leojonathanoh
changed the title
ASP with env var support for configurationASP with env var support for configuration
leojonathanoh
changed the title
ASP with env var support for configurationASP with env var support for configuration
leojonathanoh
force-pushed
the
change/docker-combine-nginx-and-php-to-a-single-image-for-both-asp-and-bf2sclone-with-env-var-support-for-configuration
branch
4 times, most recently
from
765e452
to
e565562
Compare
…th env var support for configuration In <= v3.2.0, `asp` had separate `nginx` and `php` images. Now: `asp` image containing both `nginx` and `php`, with environment variable support, and entrypoint that sets the correct permissions. Benefits: - Easier to deploy / upgrade. No need to separate `nginx` and `php` containers - Environment variable configuration means no more need to mount config into `asp` container - Entrypoint script sets permissions on volumes. `init-container` should only need to set permissions for `db` volume Notable changes: - Add documentation for upgrading docker images to v3.3.x from prior versions - Update `./docs/examples` - Add tests for production builds for examples in `./docs/examples` Closes #69
leojonathanoh
force-pushed
the
change/docker-combine-nginx-and-php-to-a-single-image-for-both-asp-and-bf2sclone-with-env-var-support-for-configuration
branch
from
e565562
to
0deb8c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In <= v3.2.0,
asphad separatenginxandphpimages.Now:
aspimage containing bothnginxandphp, with environment variable support, and entrypoint that sets the correct permissions.Benefits:
nginxandphpcontainersaspcontainerinit-containershould only need to set permissions fordbvolumeNotable changes:
./docs/examples./docs/examplesCloses #69