Fixes #1692 - improved error for unsupported commands #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the CommandName and related enums to be top level as they are used in multiple places and not a sub component of the Commmand interface.
src/main/java/io/stargate/sgv2/jsonapi/api/model/command/CommandName.java
Outdated
Show resolved
Hide resolved
src/main/java/io/stargate/sgv2/jsonapi/api/model/command/CommandName.java
Outdated
Show resolved
Hide resolved
| * The canonical list of commands the API support, any command name not listed here is not a | ||
| * command. | ||
| */ | ||
| public enum CommandName { |
There was a problem hiding this comment.
The enum name doesn't make sense, since it has more information than it's name, need to be renamed something like CommandInfo.
There was a problem hiding this comment.
this can be taken as separate PR as the name was an existing one. Created this issue for tracking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the CommandName and related enums to be top level as they are used in multiple places and not a sub component of the Commmand interface.
Fixes #1692
Which issue(s) this PR fixes:
Fixes #
Checklist