Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CommandName enum #1701

Open
maheshrajamani opened this issue Nov 13, 2024 · 1 comment
Open

Rename CommandName enum #1701

maheshrajamani opened this issue Nov 13, 2024 · 1 comment
Assignees
@maheshrajamani
Labels
Code Tidy Tidying to improve layout and quality (small) On Hold Not ready for active development

Comments

@maheshrajamani
Copy link
Contributor

The CommandName enum's name doesn't make sense, since it has more information than name, need to be renamed something like CommandInfo or CommandMetadata, etc
@maheshrajamani maheshrajamani self-assigned this Nov 13, 2024
@maheshrajamani maheshrajamani mentioned this issue Nov 13, 2024
Merged
4 tasks
@amorton amorton added On Hold Not ready for active development Code Tidy Tidying to improve layout and quality (small) labels Dec 11, 2024
@amorton
Copy link
Contributor

amorton commented Dec 11, 2024

on hold until we discuss ,the enum is holding the name of the command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maheshrajamani maheshrajamani

Labels
Code Tidy Tidying to improve layout and quality (small) On Hold Not ready for active development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amorton @maheshrajamani and others