feature: using Coral instead #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheazywi
added
enhancement
|
@coderabbitai summary |
✅ Actions performedSummary regeneration triggered. |
WalkthroughThis update introduces the Coral dependency as a new submodule, updates build configurations to use Coral instead of Mono, and removes all Mono/MSBuild-related schema and target files from the repository. The Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant Repo as Repository
participant Coral as Coral Submodule
participant BuildSys as Build System
Dev->>Repo: Add Coral as submodule
Dev->>Repo: Update .gitignore, Dependencies.lua, premake5.lua
Dev->>Repo: Remove Mono/MSBuild files
Repo->>Coral: Initialize/Update submodule
BuildSys->>Repo: Use new Coral dependency and build settings
BuildSys->>Repo: Build with .NET 8.0 and Coral
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
coderabbitai bot
added a commit
that referenced
this pull request
Jun 24, 2025
Docstrings generation was requested by @sheazywi. * #18 (comment) The following files were modified: * `StarEditor/src/EditorLayer.cpp` * `StarEditor/src/EditorLayer.h` * `StarEditor/src/Panels/SceneHierarchyPanel.cpp` * `StarEngine-ScriptCore/Source/StarEngine/FrameTime.cs` * `StarEngine-ScriptCore/Source/StarEngine/Input.cs` * `StarEngine-ScriptCore/Source/StarEngine/Math/Interpolate.cs` * `StarEngine-ScriptCore/Source/StarEngine/Math/Mathf.cs` * `StarEngine-ScriptCore/Source/StarEngine/Math/Matrix4.cs` * `StarEngine-ScriptCore/Source/StarEngine/Math/Random.cs` * `StarEngine-ScriptCore/Source/StarEngine/Math/Vector2.cs` * `StarEngine-ScriptCore/Source/StarEngine/Math/Vector3.cs` * `StarEngine-ScriptCore/Source/StarEngine/Math/Vector4.cs` * `StarEngine-ScriptCore/Source/StarEngine/Scene/AssetHandle.cs` * `StarEngine-ScriptCore/Source/StarEngine/Scene/Components.cs` * `StarEngine-ScriptCore/Source/StarEngine/Scene/ConsoleLog.cs` * `StarEngine-ScriptCore/Source/StarEngine/Scene/Entity.cs` * `StarEngine-ScriptCore/Source/StarEngine/Scene/Scene.cs` * `StarEngine/src/StarEngine/Asset/Asset.cpp` * `StarEngine/src/StarEngine/Asset/Asset.h` * `StarEngine/src/StarEngine/Asset/AssetImporter.cpp` * `StarEngine/src/StarEngine/Asset/AssetImporter.h` * `StarEngine/src/StarEngine/Asset/EditorAssetManager.cpp` * `StarEngine/src/StarEngine/Asset/SceneImporter.cpp` * `StarEngine/src/StarEngine/Asset/SceneImporter.h` * `StarEngine/src/StarEngine/Core/Application.cpp` * `StarEngine/src/StarEngine/Core/Base.h` * `StarEngine/src/StarEngine/Core/Buffer.h` * `StarEngine/src/StarEngine/Core/UUID.h` * `StarEngine/src/StarEngine/Physics/ContactListener2D.cpp` * `StarEngine/src/StarEngine/Project/Project.cpp` * `StarEngine/src/StarEngine/Project/Project.h` * `StarEngine/src/StarEngine/Scene/Entity.h` * `StarEngine/src/StarEngine/Scene/Scene.cpp` * `StarEngine/src/StarEngine/Scene/Scene.h` * `StarEngine/src/StarEngine/Scene/SceneSerializer.cpp` * `StarEngine/src/StarEngine/Scripting/CSharpObject.h` * `StarEngine/src/StarEngine/Scripting/ScriptEngine.cpp` * `StarEngine/src/StarEngine/Scripting/ScriptEngine.h` * `StarEngine/src/StarEngine/Scripting/ScriptEntityStorage.cpp` * `StarEngine/src/StarEngine/Scripting/ScriptEntityStorage.h` * `StarEngine/src/StarEngine/Scripting/ScriptFile.h` * `StarEngine/src/StarEngine/Scripting/ScriptGlue.cpp` * `StarEngine/src/StarEngine/Scripting/ScriptGlue.h` * `StarEngine/src/StarEngine/Utils/Hash.h` * `StarEngine/src/StarEngine/Utils/TypeInfo.h`
|
Note Generated docstrings for this pull request at #20 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
Sandbox/premake5.lua (1)
53-53: Consider consistent indentation.Minor formatting suggestion: use consistent indentation (spaces vs tabs) to match the rest of the file.
- buildoptions { "/utf-8" } + buildoptions { "/utf-8" }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (280)
StarEditor/mono/lib/mono/4.5/Accessibility.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Commons.Xml.Relaxng.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/CustomMarshalers.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/Microsoft.Win32.Primitives.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/Microsoft.Win32.Registry.AccessControl.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/Microsoft.Win32.Registry.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.AppContext.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Collections.Concurrent.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Collections.NonGeneric.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Collections.Specialized.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Collections.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.ComponentModel.Annotations.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.ComponentModel.EventBasedAsync.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.ComponentModel.Primitives.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.ComponentModel.TypeConverter.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.ComponentModel.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Console.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Data.Common.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Data.SqlClient.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Diagnostics.Contracts.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Diagnostics.Debug.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Diagnostics.FileVersionInfo.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Diagnostics.Process.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Diagnostics.StackTrace.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Diagnostics.TextWriterTraceListener.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Diagnostics.Tools.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Diagnostics.TraceEvent.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Diagnostics.TraceSource.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Diagnostics.Tracing.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Drawing.Primitives.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Dynamic.Runtime.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Globalization.Calendars.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Globalization.Extensions.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Globalization.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.IO.Compression.ZipFile.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.IO.FileSystem.AccessControl.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.IO.FileSystem.DriveInfo.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.IO.FileSystem.Primitives.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.IO.FileSystem.Watcher.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.IO.FileSystem.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.IO.IsolatedStorage.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.IO.MemoryMappedFiles.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.IO.Pipes.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.IO.UnmanagedMemoryStream.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.IO.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Linq.Expressions.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Linq.Parallel.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Linq.Queryable.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Linq.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Net.AuthenticationManager.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Net.Cache.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Net.Http.Rtc.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Net.HttpListener.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Net.Mail.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Net.NameResolution.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Net.NetworkInformation.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Net.Ping.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Net.Primitives.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Net.Requests.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Net.Security.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Net.ServicePoint.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Net.Sockets.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Net.Utilities.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Net.WebHeaderCollection.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Net.WebSockets.Client.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Net.WebSockets.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.ObjectModel.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Reflection.Emit.ILGeneration.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Reflection.Emit.Lightweight.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Reflection.Emit.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Reflection.Extensions.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Reflection.Primitives.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Reflection.TypeExtensions.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Reflection.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Resources.Reader.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Resources.ReaderWriter.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Resources.ResourceManager.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Resources.Writer.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Runtime.CompilerServices.VisualC.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Runtime.Extensions.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Runtime.Handles.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Runtime.InteropServices.RuntimeInformation.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Runtime.InteropServices.WindowsRuntime.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Runtime.InteropServices.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Runtime.Numerics.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Runtime.Serialization.Formatters.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Runtime.Serialization.Json.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Runtime.Serialization.Primitives.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Runtime.Serialization.Xml.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Runtime.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Security.AccessControl.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Security.Claims.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Security.Cryptography.Algorithms.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Security.Cryptography.Csp.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Security.Cryptography.DeriveBytes.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Security.Cryptography.Encoding.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Security.Cryptography.Encryption.Aes.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Security.Cryptography.Encryption.ECDiffieHellman.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Security.Cryptography.Encryption.ECDsa.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Security.Cryptography.Encryption.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Security.Cryptography.Hashing.Algorithms.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Security.Cryptography.Hashing.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Security.Cryptography.Primitives.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Security.Cryptography.ProtectedData.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Security.Cryptography.RSA.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Security.Cryptography.RandomNumberGenerator.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Security.Cryptography.X509Certificates.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Security.Principal.Windows.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Security.Principal.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Security.SecureString.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.ServiceModel.Duplex.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.ServiceModel.Http.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.ServiceModel.NetTcp.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.ServiceModel.Primitives.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.ServiceModel.Security.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.ServiceProcess.ServiceController.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Text.Encoding.CodePages.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Text.Encoding.Extensions.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Text.Encoding.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Text.RegularExpressions.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Threading.AccessControl.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Threading.Overlapped.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Threading.Tasks.Parallel.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Threading.Tasks.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Threading.Thread.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Threading.ThreadPool.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Threading.Timer.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Threading.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.ValueTuple.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Xml.ReaderWriter.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Xml.XDocument.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Xml.XPath.XDocument.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Xml.XPath.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Xml.XmlDocument.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Xml.XmlSerializer.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/System.Xml.Xsl.Primitives.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Facades/netstandard.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/I18N.CJK.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/I18N.MidEast.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/I18N.Other.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/I18N.Rare.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/I18N.West.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/I18N.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/IBM.Data.DB2.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/ICSharpCode.SharpZipLib.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Microsoft.Build.Engine.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Microsoft.Build.Framework.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Microsoft.Build.Tasks.v4.0.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Microsoft.Build.Utilities.v4.0.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Microsoft.Build.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Microsoft.CSharp.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Microsoft.CodeAnalysis.CSharp.Scripting.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Microsoft.CodeAnalysis.CSharp.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Microsoft.CodeAnalysis.Scripting.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Microsoft.CodeAnalysis.VisualBasic.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Microsoft.CodeAnalysis.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Microsoft.VisualBasic.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Microsoft.VisualC.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Microsoft.Web.Infrastructure.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.Btls.Interface.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.CSharp.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.Cairo.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.Cecil.VB.Mdb.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.Cecil.VB.Pdb.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.Cecil.VB.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.CodeContracts.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.CompilerServices.SymbolWriter.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.Data.Sqlite.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.Data.Tds.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.Debugger.Soft.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.Http.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.Management.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.Messaging.RabbitMQ.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.Messaging.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.Parallel.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.Posix.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.Profiler.Log.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.Security.Win32.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.Security.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.Simd.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.Tasklets.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.WebBrowser.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.WebServer2.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Mono.XBuild.Tasks.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/Novell.Directory.Ldap.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/PEAPI.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/RabbitMQ.Client.Apigen.exeis excluded by!**/*.exeStarEditor/mono/lib/mono/4.5/RabbitMQ.Client.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/SMDiagnostics.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Collections.Immutable.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.ComponentModel.Composition.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.ComponentModel.DataAnnotations.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Configuration.Install.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Configuration.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Core.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Data.DataSetExtensions.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Data.Entity.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Data.Linq.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Data.OracleClient.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Data.Services.Client.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Data.Services.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Data.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Deployment.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Design.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.DirectoryServices.Protocols.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.DirectoryServices.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Drawing.Design.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Drawing.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Dynamic.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.EnterpriseServices.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.IO.Compression.FileSystem.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.IO.Compression.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.IdentityModel.Selectors.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.IdentityModel.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Json.Microsoft.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Json.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Management.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Memory.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Messaging.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Net.Http.Formatting.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Net.Http.WebRequest.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Net.Http.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Net.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Numerics.Vectors.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Numerics.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Reactive.Core.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Reactive.Debugger.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Reactive.Experimental.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Reactive.Interfaces.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Reactive.Linq.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Reactive.Observable.Aliases.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Reactive.PlatformServices.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Reactive.Providers.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Reactive.Runtime.Remoting.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Reactive.Windows.Forms.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Reactive.Windows.Threading.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Reflection.Context.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Reflection.Metadata.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Runtime.Caching.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Runtime.CompilerServices.Unsafe.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Runtime.DurableInstancing.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Runtime.Remoting.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Runtime.Serialization.Formatters.Soap.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Runtime.Serialization.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Security.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.ServiceModel.Activation.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.ServiceModel.Discovery.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.ServiceModel.Internals.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.ServiceModel.Routing.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.ServiceModel.Web.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.ServiceModel.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.ServiceProcess.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Threading.Tasks.Dataflow.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Threading.Tasks.Extensions.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Transactions.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Web.Abstractions.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Web.ApplicationServices.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Web.DynamicData.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Web.Extensions.Design.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Web.Extensions.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Web.Http.SelfHost.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Web.Http.WebHost.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Web.Http.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Web.Mobile.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Web.Mvc.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Web.Razor.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Web.RegularExpressions.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Web.Routing.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Web.Services.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Web.WebPages.Deployment.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Web.WebPages.Razor.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Web.WebPages.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Web.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Windows.Forms.DataVisualization.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Windows.Forms.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Windows.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Workflow.Activities.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Workflow.ComponentModel.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Workflow.Runtime.dllis excluded by!**/*.dllStarEditor/mono/lib/mono/4.5/System.Xaml.dllis excluded by!**/*.dll
📒 Files selected for processing (13)
.gitignore(1 hunks).gitmodules(1 hunks)Dependencies.lua(1 hunks)Sandbox/premake5.lua(2 hunks)StarEditor/SandboxProject/Assets/Scripts/Source/Camera.cs(1 hunks)StarEditor/SandboxProject/Assets/Scripts/premake5.lua(1 hunks)StarEditor/mono/lib/mono/4.5/MSBuild/Microsoft.Build.CommonTypes.xsd(0 hunks)StarEditor/mono/lib/mono/4.5/MSBuild/Microsoft.Build.Core.xsd(0 hunks)StarEditor/mono/lib/mono/4.5/Microsoft.Build.xsd(0 hunks)StarEditor/mono/lib/mono/4.5/Microsoft.CSharp.targets(0 hunks)StarEditor/mono/lib/mono/4.5/Microsoft.Common.targets(0 hunks)StarEditor/mono/lib/mono/4.5/Microsoft.Common.tasks(0 hunks)StarEditor/mono/lib/mono/4.5/Microsoft.VisualBasic.targets(0 hunks)
💤 Files with no reviewable changes (7)
- StarEditor/mono/lib/mono/4.5/Microsoft.Common.tasks
- StarEditor/mono/lib/mono/4.5/Microsoft.VisualBasic.targets
- StarEditor/mono/lib/mono/4.5/Microsoft.Build.xsd
- StarEditor/mono/lib/mono/4.5/Microsoft.CSharp.targets
- StarEditor/mono/lib/mono/4.5/MSBuild/Microsoft.Build.CommonTypes.xsd
- StarEditor/mono/lib/mono/4.5/MSBuild/Microsoft.Build.Core.xsd
- StarEditor/mono/lib/mono/4.5/Microsoft.Common.targets
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: build (Debug)
- GitHub Check: build (Dist)
- GitHub Check: build (Release)
🔇 Additional comments (7)
.gitignore (1)
30-35: LGTM! Proper build artifact exclusions added.The new
.gitignoreentries appropriately exclude build artifacts, user-specific project files, and intermediate compilation outputs related to the .NET 8.0 upgrade and Coral integration..gitmodules (1)
29-31: Verify URL consistency with existing submodules.The Coral submodule addition is correct, but note the inconsistency: other submodules use relative paths (
../../) while Coral uses a full HTTPS URL. Ensure this is intentional and doesn't cause issues with different Git hosting setups.StarEditor/SandboxProject/Assets/Scripts/premake5.lua (1)
25-25: Verify .NET 8.0 upgrade in Premake and dependency compatibilityThe change from
.NET Framework 4.xto modern.NET 8.0viadotnetframework "net8.0"in your premake5.lua is a breaking‐major upgrade. Please perform the following checks before merging:• Ensure you’re using a Premake5 build that supports
dotnetframework "net8.0"(Premake 5.0.0-alpha or later).
• Regenerate your .csproj files and inspect each<TargetFramework>entry to confirm they now listnet8.0.
• Review all<PackageReference>imports in the generated projects and verify each NuGet dependency officially supports .NET 8.0.
• Confirm that StarEngine-ScriptCore (and any other in-house libraries) compile and pass their unit/integration tests under .NET 8.
• Validate your CI/CD and deployment environments have the .NET 8 SDK/runtime installed and that runtime targets (Windows, Linux, macOS) support .NET 8.Sandbox/premake5.lua (1)
29-32: LGTM! Coral integration properly configured.The library linking configuration correctly adds both yaml-cpp and Coral libraries to support the new dependency structure.
Dependencies.lua (3)
22-22: LGTM: Coral include directory added correctly.The include path follows the established pattern and points to the appropriate Coral native headers directory.
23-23: LGTM: MagicEnum include directory added correctly.MagicEnum is a header-only library, so only the include directory is needed. The path structure is consistent with other dependencies.
28-31: Please initialize and update the Coral submodule before verifying its build outputsIt looks like the
StarEngine/vendor/Coralsubmodule is registered in .gitmodules but its directory is currently empty. We can’t confirm the build output structure or library name until the Coral sources are present.• Run:
git submodule update --init --recursive• Re-inspect
StarEngine/vendor/Coralfor build scripts (CMakeLists.txt, premake5.lua, etc.)
• Verify the output directory layout underBuild/%{cfg.buildcfg}and that the produced library matchesCoral.Native.lib(or adjust the paths/names accordingly)
Comment on lines
+1
to
+3
| using StarEngine; | ||
|
|
||
| using StarEngine; | ||
|
|
||
| namespace Sandbox | ||
| namespace StarEngine; |
There was a problem hiding this comment.
Fix circular namespace reference.
There's a circular reference issue: the file imports using StarEngine; but then declares itself in namespace StarEngine;. This is likely incorrect and could cause compilation issues.
Based on the project structure, this should probably be:
using StarEngine;
-namespace StarEngine;
+namespace Sandbox;The Camera class should be in the Sandbox namespace since it's part of the SandboxProject, not the core StarEngine.
🤖 Prompt for AI Agents
In StarEditor/SandboxProject/Assets/Scripts/Source/Camera.cs at the top lines 1
to 3, remove the using directive for StarEngine and change the namespace
declaration from StarEngine to Sandbox to avoid circular namespace references
and correctly reflect that the Camera class belongs to the SandboxProject.
| @@ -20,12 +20,15 @@ project "Sandbox" | |||
| "%{wks.location}/StarEngine/vendor", | |||
| "%{IncludeDir.glm}", | |||
| "%{IncludeDir.entt}", | |||
| "%{IncludeDir.miniaudio}" | |||
| "%{IncludeDir.miniaudio}", | |||
| "%{IncludeDir.Coral}", | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Verify Coral include directory variable definition.
The Coral include directory reference looks correct, but ensure that %{IncludeDir.Coral} is properly defined in the dependencies configuration.
🏁 Script executed:
#!/bin/bash
# Verify that Coral variables are defined in Dependencies.lua or similar files
echo "Checking for Coral variable definitions..."
rg -i "IncludeDir\.Coral|Library\.Coral" --type luaLength of output: 427
🏁 Script executed:
#!/bin/bash
# Search for the IncludeDir table definition in all Lua files
echo "Looking for IncludeDir table definitions..."
rg -n "IncludeDir\s*=\s*{" --type lua
# If found, show the lines around the definition to check for a Coral entry
echo "Showing context around any IncludeDir definitions for Coral..."
rg -nC3 "IncludeDir\s*=\s*{[^}]*Coral" --type lua || echo "No direct Coral entry in IncludeDir blocks found"Length of output: 659
🏁 Script executed:
#!/bin/bash
# 1. Locate any Dependencies.lua (or similarly named) files
echo "Searching for Dependencies*.lua files..."
find . -type f -iname "Dependencies*.lua"
# 2. Search for IncludeDir table initialization
echo -e "\nSearching for 'IncludeDir = {' initializations in Lua files..."
grep -R --include="*.lua" -n "IncludeDir = {" .
# 3. Look for explicit IncludeDir.Coral assignment
echo -e "\nSearching for 'IncludeDir.Coral' definitions..."
grep -R --include="*.lua" -n "IncludeDir\.Coral" .
# 4. Look for Library.Coral assignment as well
echo -e "\nSearching for 'Library.Coral' definitions..."
grep -R --include="*.lua" -n "Library\.Coral" .Length of output: 1027
Define Coral paths in Dependencies.lua
Dependencies.lua currently initializes IncludeDir = {} and has no entries for Coral. You need to add both the include‐directory and library‐path for Coral so that %{IncludeDir.Coral} and %{Library.Coral} resolve correctly:
• File: Dependencies.lua (around line 5)
Update the tables as follows:
IncludeDir = {
Coral = "path/to/Coral/include", -- add this line
-- …other entries…
}
Library = {
Coral = "path/to/Coral/lib/Coral.lib", -- add this line (adjust filename/extension per platform)
-- …other entries…
}After adding these, the references in Sandbox/premake5.lua (and StarEngine/ and StarEditor/) will resolve without errors.
🤖 Prompt for AI Agents
In Sandbox/premake5.lua at line 24, the reference to %{IncludeDir.Coral} will
fail because Coral paths are not defined. To fix this, open Dependencies.lua
around line 5 and add entries for Coral in both IncludeDir and Library tables:
set IncludeDir.Coral to the Coral include directory path and Library.Coral to
the Coral library file path (adjusting for platform-specific extensions). This
will ensure the references in premake5.lua and other related files resolve
correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the moment what I'll do is that I will put everything already added and put more if I want to sometime.
Summary by CodeRabbit
Chores
Refactor