Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No StMaker functions if no StMaker loaded #693

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

No StMaker functions if no StMaker loaded #693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3824923
No StMaker functions if no StMaker loaded
genevb Jun 28, 2024
fbde064
second part of modification of rootlogoff.C
genevb Jun 28, 2024
72e662d
Merge branch 'main' into ROOTLOGOFF
genevb Aug 8, 2024
38e1fa7
Merge branch 'star-bnl:main' into ROOTLOGOFF
genevb Aug 13, 2024
f2c7e9b
Merge branch 'main' into ROOTLOGOFF
genevb Aug 14, 2024
2432fc6
Merge branch 'main' into ROOTLOGOFF
genevb Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions StRoot/macros/rootlogoff.C
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
{
if (TClassTable::GetDict("StMaker"))
{
StMaker* mk = StMaker::GetChain();
if (mk) {
mk->Finish();
}
gROOT->Macro("rootlogoff2.C");
Copy link
Contributor Author

@genevb genevb Jun 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (gROOT->Macro()) seems to be a more protective wrapper around gInterpreter->ExecuteMacro(), but I don't know that it's really any better in this circumstance. But if anyone else has a perspective on which is better to use, please chime in.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of a simpler solution here, short of modifying our root4star application. But that means we lose this functionality when bfc is run under root.exe. If we can register a callback with the root ".q" command, then we would be in business. But a very quick search didn't turn up anything.

}

std::cout << "\nThis is the end of STAR ROOT -- Goodbye\n" << std::endl;
Expand Down
6 changes: 6 additions & 0 deletions StRoot/macros/rootlogoff2.C
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
StMaker* mk = StMaker::GetChain();
if (mk) {
mk->Finish();
}
}
Loading