-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unresponsive reviewers from CODEOWNERS #691
base: main
Are you sure you want to change the base?
Conversation
Feel free to submit your suggestions or commit to this branch directly before it's merged. |
Frank, was it you who added ZaochenYe? There is no such github user |
Also, I don't think @ideppner has ever accepted the invitation to the |
Zaochen's GitHub ID is @Morning-Ye |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are fine with me, though Victor may still appreciate being informed of code changes even if he isn't actively reviewing anything. One could ask him before dropping him.
I'm fine with keeping anyone who is willing to own the code and monitor changes in the CODEOWNERS file. My understanding was that the goal was to reduce the list of automatically requested reviewers to streamline the approval process and speed up merging. If someone wants to be notified about specific activities, they can adjust their notification settings or star the repository. More details can be found here: GitHub Notification Settings. |
It may be good to bring that to Victor’s attention. We all agree that his expert opinion will always be much appreciated!
…-f.
On Jun 26, 2024, at 5:30 PM, Dmitri Smirnov ***@***.***> wrote:
I'm fine with keeping anyone who is willing to own the code and monitor changes in the CODEOWNERS file. My understanding was that the goal was to reduce the list of automatically requested reviewers to streamline the approval process and speed up merging. If someone wants to be notified about specific activities, they can adjust their notification settings or star the repository. More details can be found here: GitHub Notification Settings <https://docs.github.com/en/account-and-profile/managing-subscriptions-and-notifications-on-github/setting-up-notifications/configuring-notifications#choosing-your-notification-settings>.
—
Reply to this email directly, view it on GitHub <#691 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEMNVR7XY6LFE7MTUMIZVXTZJM6I5AVCNFSM6AAAAABJ6LEK22VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJSG4ZDKMZRHE>.
You are receiving this because your review was requested.
|
As discussed, we've cleaned up the CODEOWNERS file by removing unresponsive or inactive members.