Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated timebin handling by StFstRawHitMaker #685

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

jdbrice
Copy link
Contributor

@jdbrice jdbrice commented May 16, 2024

This is an important update that effects the ongoing Fast offline production of Run24 data.
This fixes the raw hit maker producing incorrect hits when the default number of time bins is not correct.

@genevb
Copy link
Contributor

genevb commented May 16, 2024

The code change appears to be straightforward. The Calibrations_fst / fstControl database currently has only 3 entries, so is the plan to populate this database table more fully to cover 2022-2025 datasets?

select entryTime,beginTime,kFstCurrentTimeBinNum from fstControl order by beginTime asc;
2022-02-03 18:35:37	2021-10-25 00:00:00	9
2022-02-04 00:59:49	2021-10-26 00:00:00	9
2022-02-04 01:06:18	2021-12-21 17:51:51	3

Thanks,
-Gene

p.s. Not a big deal and not worth worrying about now, but this table would've been a good fit under Conditions_fts instead of Calibrations_fts.

@jdbrice
Copy link
Contributor Author

jdbrice commented Jun 21, 2024

@genevb If you have no concerns could you approve this so we can merge?

@genevb
Copy link
Contributor

genevb commented Jun 22, 2024

@genevb If you have no concerns could you approve this so we can merge?

Me: "is the plan to populate this database table more fully to cover 2022-2025 datasets?"

@jdbrice
Copy link
Contributor Author

jdbrice commented Jun 24, 2024

@genevb @akioogawa @sunxuhit
Can we approve this and merge? Until this goes in the FastOffline has zero usable FST data

@akioogawa akioogawa merged commit 5098807 into star-bnl:main Jun 24, 2024
148 checks passed
jdbrice added a commit to jdbrice/star-sw-1 that referenced this pull request Aug 17, 2024
This is an important update that effects the ongoing Fast offline
production of Run24 data.
This fixes the raw hit maker producing incorrect hits when the default
number of time bins is not correct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants