feat: update online plots for several detectors #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eral offline computing
…aviour is unknown
Logging is needed
No effect but remove compile warning
merging upstream changes
bring in JevpProduction
OnlTools/StJevpBuilders/fstBuilder update
Update mtdBuilder to properly handle readout errors
jml985
requested review from
genevb,
klendathu2k,
fisyak,
R-Witt,
iraklic,
plexoos,
akioogawa and
tonko-lj
as code owners
genevb
reviewed
Apr 3, 2024
mgr/Conscript-standard
Outdated
| @@ -197,7 +197,8 @@ if ( $pkg eq "Jevp") { | |||
| . $main::PATH_SEPARATOR . "#OnlTools/Jevp/StJevpBuilders" | |||
| . $main::PATH_SEPARATOR . "#OnlTools/Jevp/StJevpViewer" | |||
| . $main::PATH_SEPARATOR . $CPPPATH; | |||
| $CPPFLAGS .= " -DQT_THREAD_SUPPORT -DQT_SHARED -DQT_NO_DEBUG "; | |||
| $CPPFLAGS .= " -DQT_THREAD_SUPPORT -DQT_SHARED -DQT_NO_DEBUG -DRTS_ENABLE_LOG "; | |||
There was a problem hiding this comment.
This was a topic of brief discussion in PR #673 ...which was left with the open question of whether there was an alternative for specifying the RTS_ENABLE_LOG flag at compile-time, as opposed to enabling it for all compilations (albeit only for the Jevp package). I have nothing to add to this review other than to say it would be good to get an answer to that question.
akioogawa
approved these changes
Apr 12, 2024
plexoos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This constitutes the running Jevp plots at the experiment, with updates for plots in several detectors. It includes files from pull request #674 which hasn't been accepted yet, but of course is running in the production code online.