-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding clang format. #436
base: main
Are you sure you want to change the base?
Adding clang format. #436
Conversation
Co-authored-by: Dmitry Kalinkin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Daniel, how do you propose to enforce the style? Have you looked at any solutions?
While you are testing your new workflow, please don't trigger the regular build. Maybe there is a better way to disable a workflow but you can just remove the yaml file temporarily |
Hi, Im' still trying to test this code - but It is hard to do this on single PC because this use github stuff. |
Will this action check only modified files? |
Hi,
in theory it checks only modified files with some extensions like cxx or
hpp (source codo in c++) that's why it took do long (default version
checked everything). I have checked on my repository and looks fine.
czw., 1 gru 2022, 21:34 użytkownik Dmitri Smirnov ***@***.***>
napisał:
… Will this action check only modified files?
—
Reply to this email directly, view it on GitHub
<#436 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCXZYB3YWE4UUZZ64SV62LWLEDVZANCNFSM6AAAAAAR46SL3Y>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Thank you Daniel for implementing this check. I tested it in #461 and I think it works as intended. However, I wonder if you saw this action https://github.com/marketplace/actions/get-all-changed-files Looks like a straight forward solution to get a list of added or modified files in a PR |
Moved from #445 (comment)
|
@plexoos |
Adding clang format to code.