Implement -format=json (for vim-go) #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to #1
|
@fatih Could you take a quick look at this and let me know if the interface is what vim-go will be able to use? I modeled it after gomodifytags, but perhaps I missed something… |
Open
|
I added the a basic integration in Vim-go (see above reference), and this PR seems to work well 👍 |
|
Is there any further work that needs to be done before this can be merged @stapelberg? Anything I can do to help? |
|
I was hoping for @fatih to weigh in, but if you say this works fine, then let’s go ahead and merge it as-is. We can always fix it later. |
|
Thanks! I'll continue with the vim-go integration and look at improving some of the other issues I reported a while ago next week, as I'll be away most of this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1