fix: ChatAdapter handling of inline field markers #8902
+38
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enitrat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8901 - a bug cause field markers to not be detected if not at the beginning of a line.
Approach
Replaced the line-by-line parsing approach with regex-based solution using
re.split()with a capturing group on field marker pattern. We then iterate, alternating between field names (odd indices) and their content (even indices), making parsing more robust to LLM answers formatting.Testing
Added a new test_chat_adapter_same_line_markers test that validates handling of multiple inline markers on the same line.