Merge arodchen's PR #60 to fix syscall and scheduler deadlock #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with s5z/zsim
…d SyscallEnterLocked to avoid waitUntilQueued time-outs due to the pin internal lock The functionality of SyscallEnter is moved to SyscallEnterUnlocked called without acquiring the Pin internal lock. The actual modification of system call arguments is done in SyscallEnterLocked with acquiring the Pin internal lock. This commit fixes the following issue: s5z#57
…e when transitioning to FF
Prevents holding the Pin internal lock in PostPatchTimeoutSyscall, when another thread is in waitUntilQueued.
Sync with s5z/zsim
Merge pull request #3 from s5z/master
If FUTEX_CLOCK_REALTIME flag is set, the timeout should be treated as absolute based on CLOCK_REALTIME.
…ll commented calls to info(...) were substututed.
…s been scheduled.
…de/asm/unistd.h does not exist, processing /usr/include/x86_64-linux-gnu/asm/unistd.h instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR 60 from upstream which addresses confirmed upstream issue 57 (syscall deadlock). Additionally, it fixes an (as yet) unconfirmed deadlock with the scheduler and "Retrying timed out system calls for the remainder of sleep time when transitioning to FF mode" (also unconfirmed).
We can cherry-pick the commits, but the syscall deadlock issue fix should be included.