fix(numeric type issue): 🐛 making sure the division returns an int #375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
While working with RAGatouille (using colbert-ai version 0.2.19) to build and subsequently update an index, I encountered an error related to the persist_to_disk method in the IndexUpdater class. The error message was:
TypeError: slice indices must be integers or None or have an __index__ method.
Analysis
Upon investigation, I identified a potential issue with the calculation of
avg_chunksize
. The value was being computed as a float, which later caused an error when attempting to use it for slicing, specifically in the calculation ofpid_end
.To resolve this, I adjusted the computation to ensure that
avg_chunksize
is an integer. However, I have some reservations about whether this change aligns with the original algorithm's intent, given that usinga // b
results in the floor of the division.Thank you for maintaining this repository !