Returning passage ID in addition to passage index #326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original repo, the index corpus tsv file requires that the pid is an integer, but there may be cases where we want it to use passage id (string) instead of passage index (int). These commits allow pid to be a non-integer and allows easy access of the passage ids after passage ranking.
If we save the passage-index-to-passage-id list (
pid_list
) in thesearcher.collection
, then we can use it to easily access passage_id after ranking as follows.