Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python2 #300

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Support Python2 #300

wants to merge 2 commits into from

Conversation

makaimann
Copy link
Collaborator

No description provided.

@yoni206
Copy link
Collaborator

yoni206 commented May 3, 2022

Is there something you could add to CI for this?

@ahmed-irfan
Copy link
Collaborator

why python2? (python2 is no longer supported -- no bug fixes or changes)

@makaimann
Copy link
Collaborator Author

makaimann commented May 5, 2022

This was requested for a project using Python 2 :P We don’t have to merge this. However, because it’s such a small change, what do you think about keeping it with a message saying Python2 isn’t officially supported? Then we could also justify not adding it to CI haha.

@yoni206
Copy link
Collaborator

yoni206 commented May 7, 2022

:)

@ahmed-irfan
Copy link
Collaborator

yeah, a message would be nice that python2 is not officially supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants