Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix multiarch builds #1409

Merged
merged 26 commits into from
Mar 18, 2024
Merged

[CI] Fix multiarch builds #1409

merged 26 commits into from
Mar 18, 2024

Conversation

serban-nicusor-toptal
Copy link
Contributor

@serban-nicusor-toptal serban-nicusor-toptal commented Feb 27, 2024

Submission Checklist

  • Run unit tests
  • Documentation
    • If a user-facing facing change was made, the documentation PR is here:
    • OR, no user-facing changes were made

Release notes

Add an optional stage to build the multiarch with a custom docker tag.
Add a variable to hold the docker tag used for multiarch builds, so developers can change it when making changes to the docker image in a PR.
Eliminate the usage of --privileged for the multiarch builds themselves.
Lock multiarch build & execution on linux && triqs agent to ensure permissions are correct across runs.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

@serban-nicusor-toptal
Copy link
Contributor Author

All changes are here I think, I'm now moving into testing this to make sure everything still works as expected.

@serban-nicusor-toptal
Copy link
Contributor Author

Hey @WardBrian this is ready for a review.
I ran 34 and 35 to make sure it build and the second run won't get permission errors.
https://jenkins.flatironinstitute.org/blue/organizations/jenkins/Stan%2FStanc3/detail/PR-1409/34/pipeline
https://jenkins.flatironinstitute.org/blue/organizations/jenkins/Stan%2FStanc3/detail/PR-1409/35/pipeline

Feel free to give it a few test runs. I've updated the description with the changes too.

Copy link
Member

@WardBrian WardBrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Are there links to runs of each of these steps working?

Jenkinsfile Outdated Show resolved Hide resolved
@serban-nicusor-toptal
Copy link
Contributor Author

@WardBrian this is ready now, see my comment above with the two jenkins urls, those are successful builds, one after another to ensure we do not run into the same error as before.

@WardBrian
Copy link
Member

Those links both seem to go to builds where the Build and push multiarch docker… is grayed out

@serban-nicusor-toptal
Copy link
Contributor Author

Oh my bad, I thought you were looking for the actual multiarch builds based on this image.
See: https://jenkins.flatironinstitute.org/blue/organizations/jenkins/Stan%2FStanc3/detail/PR-1409/29/pipeline

@serban-nicusor-toptal serban-nicusor-toptal merged commit e373212 into master Mar 18, 2024
1 check passed
@serban-nicusor-toptal serban-nicusor-toptal deleted the ci-refactor-multiarch branch March 18, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants