-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Fix multiarch builds #1409
Conversation
…uild as non-sudoer to fix permissions.
All changes are here I think, I'm now moving into testing this to make sure everything still works as expected. |
Hey @WardBrian this is ready for a review. Feel free to give it a few test runs. I've updated the description with the changes too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Are there links to runs of each of these steps working?
@WardBrian this is ready now, see my comment above with the two jenkins urls, those are successful builds, one after another to ensure we do not run into the same error as before. |
Those links both seem to go to builds where the |
Oh my bad, I thought you were looking for the actual multiarch builds based on this image. |
Submission Checklist
Release notes
Add an optional stage to build the multiarch with a custom docker tag.
Add a variable to hold the docker tag used for multiarch builds, so developers can change it when making changes to the docker image in a PR.
Eliminate the usage of
--privileged
for the multiarch builds themselves.Lock multiarch build & execution on
linux && triqs
agent to ensure permissions are correct across runs.Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)