Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark binomial logit and glm as opencl-supported #1368

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

andrjohns
Copy link
Contributor

Submission Checklist

This PR marks the binomial_logit and binomial_logit_glm distributions as OpenCL-supported. The binomial_logit_glm support was only recently added, but the binomial_logit distributions appears to have already had support but just hadn't been enabled.

Let me know if I've missed any tests/checks that also need to be made!

  • Run unit tests
  • Documentation
    • If a user-facing facing change was made, the documentation PR is here:
    • OR, no user-facing changes were made

Release notes

Enabled OpenCL support for the binomial_logit and binomial_logit_glm distributions

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.49%. Comparing base (c5721d7) to head (b4285d0).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1368   +/-   ##
=======================================
  Coverage   89.49%   89.49%           
=======================================
  Files          63       63           
  Lines       10618    10618           
=======================================
  Hits         9503     9503           
  Misses       1115     1115           
Files with missing lines Coverage Δ
src/stan_math_backend/Transform_Mir.ml 95.77% <ø> (ø)

@WardBrian
Copy link
Member

With #1353 this may be obsolete by the next release but I don't see any harm in marking it supported if it is

@andrjohns
Copy link
Contributor Author

With #1353 this may be obsolete by the next release but I don't see any harm in marking it supported if it is

Oh neat, that will be really nice to have

@andrjohns
Copy link
Contributor Author

@WardBrian would it be alright for this to go in?

@WardBrian WardBrian merged commit 41f4d0c into master Oct 2, 2024
3 checks passed
@WardBrian WardBrian deleted the binomial-opencl branch October 2, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants