-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dispatcher class to manage stan::callbacks writer objects #3337
base: develop
Are you sure you want to change the base?
Conversation
…n-dev/stan into feature/callbacks-dispatcher
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
…n-dev/stan into feature/callbacks-dispatcher
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
Submission Checklist
./runTests.py src/test/unit
make cpplint
Summary
Adds a new class
dispatcher
to stan::callbacks, used to map classes of outputs to an associated callbacks writer.Implementation of design doc https://github.com/stan-dev/design-docs/blob/master/designs/0032-stan-output-formats.md.
info_types
used to classify outputsstan::services
has singledispatcher
arg, instead of one or more callback writer args.Intended Effect
Simplify
stan::services
API calls and make it possible to add new output formats and types of outputs going forward.How to Verify
Unit tests
Side Effects
N/A
Documentation
N/A
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: