Synchronise experimental branch
#1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in hopes that allows R CMD check to pass for packages that have a stanfit object saved in the data/ directory that was created with an outdated version of RStan
This reverts commit 7d69aad.
now builds more of SUNDIALS
that currently crashes
|
Sounds good to me! |
|
It's been a week now with no arguments against, so I'm going to go ahead and merge and start moving the workflows across - but feel free to let me know if there are any reasons to revert! |
|
I think that sounds like a good plan. Thanks for doing all this @andrjohns . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's time to make the
developbranch the main source of truth forrstandevelopment, for consistency with our other reposThe plan is to:
experimentalwithdevelop(this PR)stanJenkinsfile to keep thestansubmodule (inStanHeaders) synchronised (like is done forcmdstan)stanc3Jenkinsfile/GHA to keepstanc.jssynchroniseddevelopinstead ofexperimentalAny objections/concerns?
@hsbadr @jgabry @bgoodri