Fix contrasts issue #283 and minor other changes
#284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`divergence_minimizers.R` by `c()` (duplicates get filtered out by `intersect()` anyway).
packages, so make their redefinitions only locally (to increase the burden of such usage).
is done to avoid the warning `contrasts dropped from factor <factor_name>` when predicting for each projected draw, e.g., for submodels fit with lm()/glm()
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to remove any
contrastsattributes of the original dataset's columns. This is intended as a quick fix for issue #283. However, as mentioned there, projpred should probably take the contrasts from the reference model into account when fitting the submodels. Until this is implemented, I have documented the current behavior.All other changes are minor refactorings and documentation fixes (in particular, to remove the duplicated "DOI:" prefix).
If this is merged after the upcoming CRAN release, the version number for the
NEWS.mdchange performed here needs to be adapted.