Convert lists of matrices to draws_array
objects
#387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows to convert lists of matrices to
draws_array
objects. We had to initially revert as it was causing issues in cmdstanr models with one chain (#386).In this PR I also fix the issue with
as_array_matrix_list
such that we now should no longer see any issues. Interestingly, I believe that the bug inas_array_matrix_list
existed also previously (for a long time I think). Just nobody usedas_array_matrix_list
until I made more objects to trigger it being called. Anyway it works now.@jgabry can you perhaps quickly check and confirm that it now works as expected? It passes all posterior and cmdstanr tests for me and works with one-chain models.
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: