Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve input checking and warnings for pareto diags #371

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

n-kall
Copy link
Collaborator

@n-kall n-kall commented Jun 4, 2024

Summary

Improves checking for input for pareto diagnostic functions. Fixes issue #315

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@paul-buerkner
Copy link
Collaborator

Looks good! Can I merge from your side?

@n-kall
Copy link
Collaborator Author

n-kall commented Jun 4, 2024

Yes, can be merged

Copy link

github-actions bot commented Jun 4, 2024

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 4d3ccf1 is merged into master:

  • ✔️as_draws_array: 141ms -> 141ms [-1.29%, +0.9%]
  • 🚀as_draws_df: 72.7ms -> 70.1ms [-5.2%, -1.97%]
  • ✔️as_draws_list: 171ms -> 170ms [-2.24%, +0.27%]
  • ✔️as_draws_matrix: 27.9ms -> 27.8ms [-1.57%, +0.26%]
  • ✔️as_draws_rvars: 83ms -> 83ms [-0.84%, +1.04%]
  • 🚀summarise_draws_100_variables: 745ms -> 741ms [-0.84%, -0.12%]
  • ✔️summarise_draws_10_variables: 114ms -> 114ms [-0.58%, +1.31%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@paul-buerkner paul-buerkner merged commit 44fc43e into stan-dev:master Jun 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants