Change pareto functions to return unnamed numerics #370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This changes
pareto_*
functions to no longer return named numeric values if there is just a single value output.This applies to
pareto_khat
,pareto_khat_threshold
,pareto_min_ss
, andpareto_convergence_rate
.pareto_diags
returns a named vector of all of these. Andpareto_smooth
is not affected by this.This also changes the return type of
pareto_khat
to be an unnamed numeric rather than a list, which would require a change in loo (specifically E_loo). As there is already an issue that needed to be worked around (stan-dev/loo/issues/263) I think this is worth addressing now.This would close #359 and #346
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: