Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variadic argument lists for ODEs #1641
Variadic argument lists for ODEs #1641
Changes from 250 commits
2d696c8
8a1d99e
6d8ad8a
1a54bde
f689c93
0da9de0
73fb5ae
e7a83c6
2a370e7
bd13907
e1deb4f
358525c
13641ea
5f76ca2
d9e5276
5e01bf0
f2ed8a9
a3b4ad4
f3b37ae
940fc82
8b66f94
e56cdf2
2cece58
71c0196
e2b20d7
c0c118a
ff0f582
96e8c8e
3d62fa8
cbcf42f
8f90d8c
617d6e2
fbfa9ba
008255e
00e5743
623ed9e
16db0f2
9305fb0
bb9a1b2
430ba3f
0248bcb
b2c1dec
cf8b530
a27047f
2dd8881
5e3e078
92fe766
2d1d57e
906c262
747c73a
3da42ff
70001ac
be1ff0c
7a6b558
d440aab
89bad42
c1ac292
4ea5f1c
6075dcc
af7791e
103333c
ab1e653
29f1f71
37b516f
b76cd8c
6b93f93
e804157
66acef6
906d7b0
71d8c71
d05d452
658755d
4e18f1e
d834a4f
145ae95
9957909
3ecf79e
3c56f6d
cf48965
94989a0
c9ac276
70546f4
4cfcfe8
d46c022
ccc82e7
87a86ea
6c88e6a
144bb9c
4adf05d
80ae1bf
7a1a27b
9e15292
b6b215b
66ba573
a5a50e2
55171a4
bc3b7c6
89d0781
e8b0294
a017619
2561972
3e36ba8
38aa2af
b99d299
cc37f22
b64fe87
7d27f90
c53d29d
fb9f25a
86bf06a
ee1e0d7
7aa19ce
cb57e75
09d3f52
3522bbe
80449e0
12f6ad9
a2e9c92
64a017e
b8168e1
2a3d24a
085c3bc
8642b08
f1d7b6c
a3a3121
7a8e3d5
e012d1f
03756de
2cc1f3d
257afa0
a3530bb
e3e2b9e
8bf8b87
9553f64
cb602ad
36a15e2
9831634
44529fd
e9cca92
92314d0
c719ec5
7b3f7b7
94fdd3e
1b2b066
962ba83
e6d7dcf
46d7230
7f5e7db
61cfd25
d962970
7007256
ad58f9d
8c1a10d
8bd267f
8f28f3e
4ca2912
8dfa0d1
b4e89d3
a1f928b
f16df92
ae99813
ea303ff
ae43edf
c982322
6ae558c
4ad49f4
0eb1382
961780f
3b5f18d
dfdd989
5668b09
11605da
a1db0b4
28affd2
c42eec7
27d4f49
69e5f86
1038387
bae0be9
573dc1a
0eff931
9a10def
1fc074c
9c82020
18f5c2d
1ef29d9
e65fb97
9a84b50
4851d6b
9592cba
d4f8fe1
cbdace5
9f923e8
40ba7a8
3b3a9f3
7e411bc
52c85a4
158ec02
8ab9809
b76e7a5
ea0f8b8
ce1377a
64805e3
467b53a
393b2c9
66bf060
0ce1fe5
2b53b2d
f745294
c045a69
444ae2a
b8bc8e4
9f62feb
56196a3
15eb4ec
efd5763
5773195
6d365ce
0c18338
7538e97
1a732b0
c2499be
5f216f4
29cde14
35267b1
c6a687d
4646593
19e029c
51e8f24
7a42c5a
3e7abbf
879510e
54de59b
509f7b2
10acf66
ab7c503
0ce6e18
a5ee85d
49bfc45
2e83467
9c7f88d
3b4c217
a589de9
a37be47
43fb63b
0d2e975
1908f1c
a3f438b
e51700b
bec1c2a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a feeling we'd need that sooner or later.
Why pass by value? I think const ref should be used here.
Also I think the first overload should be used for plain types (you can use
require_same<std::decay_t<T>, plain_type_t<T>>
instead ofrequire_eigen
), as their eval just returns a const refrence and original object might go out of scope before the reference is used for rvalue arguments.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
require_same<std::decay_t<T>, plain_type_t<T>>
That's a better way to implement this. Now not all eigen types get
const
added out front.Why pass by value?
Wasn't thinking right. const ref is right here.