Test diff winflags

stan-dev · Jan 22, 2024 · c4d2461 · c4d2461
1 parent b5736f7
commit c4d2461
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/R/model.R b/R/model.R
@@ -655,11 +655,6 @@ compile <- function(quiet = TRUE,
     if (os_is_linux()) {
       env_vars <- c(env_vars, "CXXFLAGS"="-fPIC")
     }
-    if (os_is_windows() && is_ucrt_toolchain()) {
-      cxx <- "x86_64-w64-mingw32.static.posix-g++"
-      cc <- "x86_64-w64-mingw32.static.posix-gcc"
-      env_vars <- c(env_vars, "CXX"=cxx, "CC"=cc)
-    }
 
     withr::with_path(
       c(

diff --git a/R/utils.R b/R/utils.R
@@ -745,18 +745,24 @@ with_cmdstan_flags <- function(expr) {
   }
   lib_paths <- c("/stan/lib/stan_math/lib/tbb/",
                  "/stan/lib/stan_math/lib/sundials_6.1.1/lib/")
+  new_makevars <- c(
+    USE_CXX14 = 1,
+    PKG_CPPFLAGS = ifelse(cmdstan_version() <= "2.30.1", "-DCMDSTAN_JSON", ""),
+    PKG_CXXFLAGS = paste(cxxflags, cmdstanr_includes, r_includes, collapse = " "),
+    PKG_LIBS = libs
+  )
+  if (os_is_windows() && is_ucrt_toolchain()) {
+    cxx <- "x86_64-w64-mingw32-g++"
+    cc <- "x86_64-w64-mingw32-gcc"
+    new_makevars <- c(new_makevars, "CXX" = cxx, "CC" = cc)
+  }
   withr::with_path(
     c(
       paste0(cmdstan_path(), lib_paths),
       toolchain_PATH_env_var()
     ),
     withr::with_makevars(
-     c(
-       USE_CXX14 = 1,
-       PKG_CPPFLAGS = ifelse(cmdstan_version() <= "2.30.1", "-DCMDSTAN_JSON", ""),
-       PKG_CXXFLAGS = paste(cxxflags, cmdstanr_includes, r_includes, collapse = " "),
-       PKG_LIBS = libs
-     ),
+     new_makevars,
      expr
     )
   )