Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor message, send_msg(), sign() #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RoDmitry
Copy link

  • New send_msg(&mut self, message: &Message<'x>) to send message which was already transformed using IntoMessage. Now you can have owned Message, so if any error occurs, you don't loose the entire message, so you can send it again.
  • New sign(&mut self, signer: &DkimSigner<_>) method on Message, which signs message in place, and then message can be sent using usual send().
  • Couple #[inline], because compiler does not inline by default, as far as I know, so you need to tell it which function you think may be inlined. It improves performance.
  • Sized traits

@RoDmitry RoDmitry changed the title Refactor message: send_msg(), sign() Refactor message, send_msg(), sign() Jun 22, 2023
@RoDmitry
Copy link
Author

Feel free to give feedback in case you’re interested in merging only part of these changes.

@mdecimus
Copy link
Member

Feel free to give feedback in case you’re interested in merging only part of these changes.

Hi, I won't have time to review this PR until Stalwart Mail Server reaches v1.0.0.

@RoDmitry RoDmitry force-pushed the send_msg branch 2 times, most recently from 63170ef to 737f51d Compare April 12, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants