Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle unknown and rm unused compressions #39

Merged
merged 1 commit into from
May 2, 2024
Merged

Handle unknown and rm unused compressions #39

merged 1 commit into from
May 2, 2024

Conversation

nyurik
Copy link
Collaborator

@nyurik nyurik commented May 2, 2024

  • we only need gzip for now, so remove brotli and zstd
  • add a new error case when dir compression is unsupported
  • bump reqwest version dep
  • add clippy warnings on unwrap and todo

@nyurik
Handle unknown and rm unused compressions
ccd7e55 
* we only need gzip for now, so remove brotli and zstd
* add a new error case when dir compression is unsupported
* bump reqwest version dep
* add clippy warnings on unwrap and todo
@nyurik nyurik requested a review from lseelenbinder May 2, 2024 18:36
@nyurik
Copy link
Collaborator Author

nyurik commented May 2, 2024

Note that zstd feature was just added in #38 and was never released, so can safely just drop it. CC: @RobWalt

ianthetechie
ianthetechie approved these changes May 2, 2024
View reviewed changes
Copy link

@ianthetechie ianthetechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually do intend to add brotli and zstd support, but as it just panicked, I have no objection to removing the dependency until it's actually used ;)

@ianthetechie ianthetechie merged commit 3012fc4 into stadiamaps:main May 2, 2024
2 checks passed
@nyurik nyurik deleted the unpanick branch May 2, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianthetechie ianthetechie ianthetechie approved these changes

@lseelenbinder lseelenbinder Awaiting requested review from lseelenbinder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nyurik @ianthetechie