Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Directory::get_approx_byte_size and bump MSRV #29

Merged
merged 2 commits into from
Dec 24, 2023
Merged

Add Directory::get_approx_byte_size and bump MSRV #29

merged 2 commits into from
Dec 24, 2023

Conversation

nyurik
Copy link
Collaborator

@nyurik nyurik commented Dec 23, 2023

For cache eviction purposes, it is important to know the size of the directory objects. Also, I ran cargo msrv to figure out the minimal one.

@nyurik
Add Directory::get_approx_byte_size and bump MSRV
3696b96 
For cache eviction purposes, it is important to know the size of the directory objects.  Also, I ran `cargo msrv` to figure out the minimal one.
lseelenbinder
lseelenbinder approved these changes Dec 24, 2023
View reviewed changes
Copy link
Member

@lseelenbinder lseelenbinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nyurik nyurik merged commit e95a0a3 into stadiamaps:main Dec 24, 2023
1 check passed
@nyurik nyurik deleted the dir-size branch December 24, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lseelenbinder lseelenbinder lseelenbinder approved these changes

@ianthetechie ianthetechie Awaiting requested review from ianthetechie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nyurik @lseelenbinder