Directory Caching trait #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
force-pushed
the
cache
branch
3 times, most recently
from
4f6a7e3
to
2786f24
Compare
nyurik
force-pushed
the
cache
branch
4 times, most recently
from
0909c54
to
76c5130
Compare
lseelenbinder
requested changes
Nov 10, 2023
lseelenbinder
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cache implementation adds a new
DirectoryCachetrait and a few helpers.DirectoryandEntryare now public, but neither have any public functions except forfind_tile_idwhich cache should use while locking its internal state if needed.